mikluko/multiproxy
Watch
1
0
Fork
You've already forked multiproxy
 0
Code Issues Pull requests Projects Releases 2 Packages Activity Actions

MITM certificates name the requested host as a SAN #28

Merged
mikluko merged 2 commits from fix/mitm-san into main 2026-10-26 20:51:47 +00:00
Conversation 0 Commits 2 Files changed 6 +42 -13
mikluko commented 2026-10-26 20:50:27 +00:00
Owner
Copy link

Closes #4.

The eTLD+1 error check in certForRequest was inverted: an ordinary hostname got a CN and no DNSNames, which Go clients refuse. Every certificate now names the requested hostname, or its IP, as a SAN. No wildcard: the cache is keyed per host anyway.

Also commits the !.forgejo line in .gitignore.

Closes #4. The eTLD+1 error check in `certForRequest` was inverted: an ordinary hostname got a CN and no DNSNames, which Go clients refuse. Every certificate now names the requested hostname, or its IP, as a SAN. No wildcard: the cache is keyed per host anyway. Also commits the `!.forgejo` line in `.gitignore`.
MITM certificates name the requested host as a SAN
All checks were successful
CI / changelog (pull_request) Successful in 6s
Details
CI / test (pull_request) Successful in 1m6s
Details
6dc699f356
 
The eTLD+1 error check was inverted, so an ordinary hostname got a CN and
no DNSNames, which Go clients refuse.
mikluko deleted branch fix/mitm-san 2026-10-26 20:51:47 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug
Something isn't working

  
dependencies
Pull requests that update a dependency file

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
question
Further information is requested

  
wontfix
This will not be worked on

No labels
bug
dependencies
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
mikluko/multiproxy!28
No description provided.