mikluko/multiproxy
Watch
1
0
Fork
You've already forked multiproxy
 0
Code Issues Pull requests Projects Releases 2 Packages Activity Actions

Plain-HTTP requests obey the CONNECT host rules #30

Merged
mikluko merged 1 commit from fix/http-host-rules into main 2026-10-26 20:57:44 +00:00
Conversation 0 Commits 1 Files changed 4 +72 -9
mikluko commented 2026-10-26 20:57:11 +00:00
Owner
Copy link

Closes #7.

Router.Default forwarded every absolute-URI request without matching its host. A plain-HTTP request now reaches Default only when a CONNECT host pattern matches its host or a Connect fallback is set. Anything else gets 403 Forbidden, from the new router.Forbidden handler.

This breaks library users who set Default with no host rules: they now get a 403 for every host. The changelog says so.

Closes #7. `Router.Default` forwarded every absolute-URI request without matching its host. A plain-HTTP request now reaches `Default` only when a `CONNECT` host pattern matches its host or a `Connect` fallback is set. Anything else gets `403 Forbidden`, from the new `router.Forbidden` handler. This breaks library users who set `Default` with no host rules: they now get a 403 for every host. The changelog says so.
Plain-HTTP requests obey the CONNECT host rules
All checks were successful
CI / changelog (pull_request) Successful in 6s
Details
CI / test (pull_request) Successful in 21s
Details
3af10ef961
 
Router.Default forwarded every absolute-URI request, so -mitm example.com
alone still proxied plain HTTP to any host.

Closes #7
mikluko deleted branch fix/http-host-rules 2026-10-26 20:57:45 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug
Something isn't working

  
dependencies
Pull requests that update a dependency file

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
question
Further information is requested

  
wontfix
This will not be worked on

No labels
bug
dependencies
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
mikluko/multiproxy!30
No description provided.