Raise test coverage to 90% #34

Merged

mikluko merged 1 commit from test/coverage into main

2026-10-26 21:11:40 +00:00

mikluko commented

2026-10-26 21:10:06 +00:00

Owner

Total statement coverage goes from 70.7% on the modernised main to 90.4%.

The command body moves from main into run, which returns the exit status instead of calling os.Exit through zap.Fatal. That lets tests cover -print-ca, startup failures, and serving both listeners. Exit codes are unchanged: 2 for usage, 1 for other failures.

The other new tests cover behaviour that had none: log helpers outside the middleware, request IDs and sequence numbers, HTTP handler error mapping and X-Forwarded-For, MITM with an inner handler that hijacks, CA file errors, and SOCKS reply mapping.

CI runs the tests with -race and writes total coverage to the job summary. There is no coverage threshold.

Total statement coverage goes from 70.7% on the modernised `main` to 90.4%. The command body moves from `main` into `run`, which returns the exit status instead of calling `os.Exit` through `zap.Fatal`. That lets tests cover `-print-ca`, startup failures, and serving both listeners. Exit codes are unchanged: 2 for usage, 1 for other failures. The other new tests cover behaviour that had none: log helpers outside the middleware, request IDs and sequence numbers, HTTP handler error mapping and `X-Forwarded-For`, MITM with an inner handler that hijacks, CA file errors, and SOCKS reply mapping. CI runs the tests with `-race` and writes total coverage to the job summary. There is no coverage threshold.

mikluko added 1 commit

2026-10-26 21:10:06 +00:00

Raise test coverage from 70.7% to 90.4%

CI / changelog (pull_request) Successful in 6s

Details

CI / test (pull_request) Successful in 1m7s

Details

514d893470

The command body moves from main into run, which returns the exit status,
so -print-ca, startup failures and serving are tested. New tests cover the
log helpers outside the middleware, HTTP handler error mapping and
X-Forwarded-For, MITM with a hijacking inner handler, CA file errors and
SOCKS reply mapping.

CI runs the tests with -race and reports total coverage in the job summary.

mikluko merged commit 547c5fcfa0 into main

2026-10-26 21:11:40 +00:00

mikluko deleted branch test/coverage

2026-10-26 21:11:40 +00:00

mikluko referenced this pull request from a commit

2026-10-26 21:11:41 +00:00

Merge pull request 'Raise test coverage to 90%' (#34) from test/coverage into main