mikluko/nats-operator
Watch
1
0
Fork
You've already forked nats-operator
 0
Code Issues 2 Pull requests 13 Projects Releases 8 Packages Activity Actions

internal/natscluster: clients.from admits the client port from named peers #68

Open
mikluko wants to merge 1 commit from mikluko/clients-from into main AGit
pull from: mikluko/clients-from
merge into: mikluko:main
Conversation 0 Commits 1 Files changed 9 +431 -20
mikluko commented 2026-10-24 08:35:28 +00:00
Owner
Copy link

NetworkPolicies are additive, so a second policy over the same pods could
not narrow the client port the rendered one admitted from anywhere. The
cluster controller's namespace stays admitted: the controllers dial the
client port.

Closes #67

NetworkPolicies are additive, so a second policy over the same pods could not narrow the client port the rendered one admitted from anywhere. The cluster controller's namespace stays admitted: the controllers dial the client port. Closes #67
internal/natscluster: clients.from admits the client port from named peers
Some checks failed
CI / zizmor (pull_request) Failing after 2s
Details
CI / helm (pull_request) Failing after 8s
Details
CI / changelog (pull_request) Failing after 2s
Details
CI / go test (pull_request) Failing after 41s
Details
CI / go race (pull_request) Failing after 41s
Details
CI / go envtest (pull_request) Failing after 41s
Details
CI / stories (pull_request) Failing after 5s
Details
CI / stories-1 (pull_request) Failing after 6s
Details
CI / acceptance (every namespace) (pull_request) Failing after 0s
Details
CI / acceptance (watched namespaces) (pull_request) Failing after 0s
Details
CI / actionlint (pull_request) Successful in 1m11s
Details
CI / renovate (pull_request) Successful in 1m50s
Details
CI / govulncheck (pull_request) Failing after 17m7s
Details
bb84c6573b
 
NetworkPolicies are additive, so a second policy over the same pods could
not narrow the client port the rendered one admitted from anywhere. The
cluster controller's namespace stays admitted: the controllers dial the
client port.

Closes #67
Some checks failed
CI / zizmor (pull_request) Failing after 2s
Details
CI / helm (pull_request) Failing after 8s
Details
CI / changelog (pull_request) Failing after 2s
Details
CI / go test (pull_request) Failing after 41s
Details
CI / go race (pull_request) Failing after 41s
Details
CI / go envtest (pull_request) Failing after 41s
Details
CI / stories (pull_request) Failing after 5s
Details
CI / stories-1 (pull_request) Failing after 6s
Details
CI / acceptance (every namespace) (pull_request) Failing after 0s
Details
CI / acceptance (watched namespaces) (pull_request) Failing after 0s
Details
CI / actionlint (pull_request) Successful in 1m11s
Details
CI / renovate (pull_request) Successful in 1m50s
Details
CI / govulncheck (pull_request) Failing after 17m7s
Details
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin +refs/pull/68/head:mikluko/clients-from
git switch mikluko/clients-from

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff mikluko/clients-from
git switch mikluko/clients-from
git rebase main
git switch main
git merge --ff-only mikluko/clients-from
git switch mikluko/clients-from
git rebase main
git switch main
git merge --no-ff mikluko/clients-from
git switch main
git merge --squash mikluko/clients-from
git switch main
git merge --ff-only mikluko/clients-from
git switch main
git merge mikluko/clients-from
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
accessibility
Barrier affecting people with disabilities

  
bug
Something isn't working

  
dependencies
Pull requests that update a dependency file

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
go
Pull requests that update go code

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
question
Further information is requested

  
wontfix
This will not be worked on

No labels
accessibility
bug
dependencies
documentation
duplicate
enhancement
go
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
mikluko/nats-operator!68
No description provided.